[pull] master from bitcoin:master #121
Open
+22,419
−2,153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
BIP150: Deferred More robust and private protocols have been drafted and need to be formalized into a BIP
159: Mark as final
- An error test vector doesn’t specify the InvalidContributionError type - In *DeterministicSign*, use GetXonlyPubkey instead of GetPubkey - The key_agg_and_tweak fn doesn’t specify the return type - In partial_sig_verify_internal, the pubkey arg should be PlainPk - Remove unused enumerate() fn calls - In test_sign_verify, add an additional assert statement
Fix typos
BIP46 clarify witness
(cherry picked from commit 4f2e6e7)
bip327: minor fixes
Remove trailing whitespace from all BIPs
BIP 324: fix python aad in complete_handshake
It seems confusing to call BIP 353 names "addresses", and most of the BIP refers to them as "names", but a few "human-readable addresses" snuck in in a recent change, which are fixed here.
Add BIP94: Testnet 4
Co-authored-by: Mark "Murch" Erhardt <murch@murch.one>
BIP94: Change timewarp delta to 7200 seconds
BIP3: Updated BIP Process
e.g. that NODE_NETWORK is not set See reference implementation bitcoin/bitcoin#10387 and this comment in that pull bitcoin/bitcoin#10387 (comment)
Not the same meaning, so not a purely editorial fixup, but I think "unwittingly" expresses the intended meaning.
BIP3: Address follow-ups from #1712
* Correct type error in sample JSON * first pass: moar data * more fiat and edits * more edits * add per-txn value * Update bip-0329.mediawiki Co-authored-by: Jon Atack <jon@atack.com> * Update bip-0329.mediawiki Co-authored-by: Jon Atack <jon@atack.com> * Update bip-0329.mediawiki Co-authored-by: Jon Atack <jon@atack.com> * Update bip-0329.mediawiki Co-authored-by: Jon Atack <jon@atack.com> * Update bip-0329.mediawiki Co-authored-by: Jon Atack <jon@atack.com> * Update bip-0329.mediawiki Co-authored-by: Jon Atack <jon@atack.com> * Update bip-0329.mediawiki Co-authored-by: Jon Atack <jon@atack.com> * Update bip-0329.mediawiki Co-authored-by: Jon Atack <jon@atack.com> * edit * include @craigraw feedback * typo fix * add comment * further edits * broaden uses for address.heights --------- Co-authored-by: Jon Atack <jon@atack.com>
BIP 94: Move status to Final
Signed-off-by: costcould <fliter@myyahoo.com>
BIP75: fix BIP70 extensions url and clarify text
BIP329: PR 1750 follow-up edits
BIP159 updates
* BIP374: Add message to rand computation * BIP374: Update reference and test vectors * Add changelog * Format changelog according to BIP3 * Add creation date Co-authored-by: Jon Atack <jon@atack.com> * Grammar fix Co-authored-by: Jon Atack <jon@atack.com> * update changelog --------- Co-authored-by: Jon Atack <jon@atack.com>
BIP-0094: add default p2p port for testnet4
…n-BIP119 BIP119: appease typos linter
BIP94 PR1781 editorial fixups
BIP119 fix grammatical typos
Author confused bip-0341, which defines the Taproot construction, with bip-0342, which defines the
Tapscript scripting system. Unknown key types are defined in the latter, as part of the semantics of
the CHECKSIG{VERIFY} and CHECKSIGADD opcodes.
bip-0348: correct BIP number in referencing unknown key types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )